[BUG] Safari 14 requirement on desktop not detected #282
Comments
|
Hey there 👋🏼 Thanks for your first issue. This is an automated message but a real human will handle your issue very shortly. |
|
Ah, okay, the app only works in Safari 14+ … however I didn't run into any error message stating so, as is described in #54 (comment) 🤷♂️ |
|
Hey there 😃 |
|
This issue seems to be a little bit old and no ones seems to be able to help 😕. Or waiting for more informations from the reporter ⏳. If no new activity, It will be closed in 5 days |
|
That's weird, you should have seen a message. However, there's no feature detection mechanism for bigInt I know, so I need to rely on parsing the userAgent, which is not always reliable to guess which version you are using :/ |
clawfire
changed the title
clawfire
changed the title
clawfire
added
the
Next release
|
A fix is on its way 😃 |
* release/2.2.0: Bump version number Fixes #282 : add detection support for Safari < 14 on desktop added default tz into formatDate updated ua-parser-js (security issue) Add CZ instructions Bump version number and write changelog Last minute language fix Handle when we don't decode any relevant data URL detection for #126 Remove 💀 dead code Add function documentation Trying to put some orders on where to define what Fixes #23 : Ask the device for environment camera if available Updating libs router fix Fixes #152 central date string management Issue #125 Implement Apple's ignore timeZone instruction Forgot that one here it remove the urn pattern Fix when urn:uvci is lowercase
|
Ah, gotcha! I see it now. However, that doesn't work as
Maybe a parseFloat() would be the right choice? As:
I'd propose a PR however you'd prolly want to test it more than my code smell knowledge goes…;] |
|
hum. Can't really use |
|
@clawfire Yup, it parses 3.14whatever to 3.14 just fine… which is good enough for this major version comparison needed I guess. But I'd rather let that to whatever is your liking, algorithm-wise;) |
What happened?
After successfully recognizing a QR on camera, the app stops on unhandled promise rejection. ReferenceError in
@cbor/lib/constants.jsas in the screen shot attached.What browsers are you seeing the problem on?
Safari (desktop 13.1.3)
Are you browsing using
a computer (macOS Catalina 10.15.7)
Anything else?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.3 Safari/605.1.15https://www.whatismybrowser.com/w/9F68GL4The text was updated successfully, but these errors were encountered: