new preview + share pane #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _ = require('lodash'), | ||
| previewSizes = { | ||
| small: { w: 375, h: 660 }, | ||
| medium: { w: 768, h: 1024 }, |
There was a problem hiding this comment.
I think our "medium" screen size in clay is 600? That's what we base our css off of at least
There was a problem hiding this comment.
our breakpoint is 600 (for the most part), but I think the most common "tablet-ish" screen width is 768
There was a problem hiding this comment.
That's what everyone tells me but it seems like we use them both arbitrarily :\ Another thing on the list of stuff I'd like to standardize across design + dev.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Actions
Share Actions