Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump depedencies and true up implementation details. #183

Merged
merged 1 commit into from Mar 4, 2021

Conversation

phyllisstein
Copy link
Contributor

@phyllisstein phyllisstein commented Mar 3, 2021

These changes upgrade as many of Clay CLI’s dependencies as possible without breaking sites builds. This derisks additional work to integrate Webpack into Clay’s build pipeline: we can now be more confident that Webpack and its dependencies won’t break Clay and its dependencies, and vice versa.

Clay CLI’s tests needed cosmetic changes, but otherwise continue to pass. sites builds on my local machine, and a feature-branch deployment will be up shortly. (See nymag/sites#9736.)

@phyllisstein phyllisstein added ready for review dependencies Pull requests that update a dependency file labels Mar 3, 2021
@phyllisstein phyllisstein self-assigned this Mar 3, 2021
Copy link
Contributor

@mattoberle mattoberle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
I see that the js-yaml changes align with the deprecation of the safe* API in 4.0.0.

With 26 direct dependencies all getting a major version change the additional testing on a nymag/sites feature branch definitely makes sense.

@phyllisstein
Copy link
Contributor Author

Thanks for taking a look. I’ve got sites#clay-pack-spike pinned to this Git branch. Would it be better, to your mind, to deploy a prerelease claycli? I’m never not suspicious of Node version management.

@coveralls
Copy link

coveralls commented Mar 4, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 52826b4 on upgrade-dependencies into f42e748 on master.

@phyllisstein phyllisstein merged commit efd5e0c into master Mar 4, 2021
@phyllisstein phyllisstein deleted the upgrade-dependencies branch March 4, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants