Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing issue #52 "ALL conditional helpers can be inline" #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tonicblue
Copy link

As stated by @amycheng in issue "ALL conditional helpers can be inline #52", compare and modulo can both be used inline. It would be super useful to allow ifAll, ifNone, ifAny, and unlessAll to work in the same way.

Tried to keep things as simple as possible and copied the way you've written unit tests for everything so there is still the same coverage. I am now however returning false instead of an empty string. Am happy to continue to return an empty string if you'd prefer. Also, like modulo but unlike an inline if you cannot provide an else="stuff".

Hope this is all acceptable,
Cheers for the module

@jonwinton
Copy link
Contributor

Hey @tonicblue , sorry for the slow response. We'll look into getting this merged once we identify why Travis didn't build properly.

Sorry for the slow response!

@tonicblue
Copy link
Author

That's cool. Sorry I'm now slow to respond too! If it's a quick and easy to describe build issue that I can address just let me know and I'll give it a shot.

Cheers

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 99.55% when pulling ebdbda4 on scvodigital:master into a1fb8b3 on clay:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants