Fix force update after unmount #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is already checked in the guard
was redundant with documented code
changeOptions should only be declared once
to make style consistent with subscribe/unsubscribe, which use similar constructs for checking preconditions
This way we will be able to mixin multiple times
|
👍 I think these all make sense. |
Closed
also added use strict to ensure this won't happen again
used parameters instead of binding to this. Thanks to @EamonNerbonne for the suggestion
|
Thank you! FWIW, I ran into the issues noted here: facebook/react#1247 (referenced: #9). I was about to start slinging code around like I owned the place, but I checked the project's repo and found you already fixed it. Thanks again! Extracting the Backbone view conversion code into its own mixin makes sense. I converted from Marionette to React/react.backbone with just the BackboneMixin from this pull request. I wouldn't use the view methods. Migrating from Backbone/Marionette to React involves a bit more than changing dependencies; it's worthwhile to commit completely to the React philosophy and recast the views in a completely React-ified light. |
|
Superseded by #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I did several things.
I unified the behaviour for collections and models. both debounce their events now, and both support onModelChange.
Secondly, I unified some constructs. So guard statements are now all guard statements, instead of sometimes surrounding ifs for instance.
I extracted _subscribe and _unsubscribe. This means that if you add another mixin which defines _subscribe, or define _subscribe yourself, it will still work. This also means, it would conceptually be possible to mixin BackboneMixin multiple times.
I made the model mixin more similar to the other stuff mixed in. I extracted the 'view' methods, which make a component more like a backbone view, to a mixin. Now createbackboneClass only adds two mixins.
Other than that it's mostly small fixes.
I'm interested in discussing the choices in this. We need a class/mixin which provides binding for backbone models for react components. I personally think the 'view'-methods (getModel, model, el) aren't a good idea, and are mainly useful for conversion from Backbone Views to React Components. But when you are converted, they're only confusing, as they add non-standard stuff to react, while saving very little.
I'm not sure where you want to take the library, so I'm not sure if you like all the changes. If you disagree with me on the latter point, it might be better for me to start my own library, but I'd rather not (and I don't think at this point it's needed, as I just can use the mixin, and avoid using createBackboneClass).