Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for resolving variable references #8

Merged
merged 1 commit into from Jun 1, 2018

Conversation

ombran
Copy link
Contributor

@ombran ombran commented May 30, 2018

When I use a variable in a custom property of serverless.yml, its value was not resolved.
For example, (this environment variable could not use.)

custom:
  prune:
    automatic: true
    number: ${env:ENV_PRUNE_NUMBER}

Since the variable is not resolved in the constructor, it must be acquired by hook side. So I Fixed.
( FYI: https://forum.serverless.com/t/serverless-plugin-resolving-variable-references/2233 )

@coveralls
Copy link

coveralls commented May 30, 2018

Coverage Status

Coverage increased (+0.1%) to 92.958% when pulling 01ad168 on ombran:master into 86455c1 on claygregory:master.

@claygregory claygregory merged commit 47ceb59 into claygregory:master Jun 1, 2018
@claygregory
Copy link
Owner

Thanks @ombran! Merged and released as v1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants