-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullwidth captions don't expand link syntax #23
Comments
Is the fullwidth tag on it's own line? It needs to be the only text on that line in your Markdown document.
|
The source HTML looks something like this: """ {% fullwidth 'assets/img/internet_eireann_feb_1995_p.jpeg' "A 1995 paper leaflet advertising IE's services (via http://brandnewretro.ie/2012/08/23/old-adverts-88-internet-eireann-1995/" %} This leaflet advertises a number of wonderful facilities, ... which results in the following screenshot: https://www.dropbox.com/s/6yv8nm1qne8hqno/Screenshot%202015-12-31%2023.42.08.png?dl=0 (in this screenshot I use the syntax, but it was the same when it was |
And that looks like we need to use something to clear the float on that full-width image. I hope everyone realizes that this CSS came from the Tufte-CSS repo. If I had written it all, it would be much, much worse. On Dec 31, 2015, at 6:56 PM, niallrmurphy notifications@github.com wrote:
|
@niallrmurphy try escaping your apostrophe in
Or you can replace the single quotation mark with the HTML entity for the apostrophe
|
@clayh53 I think this is just a matter of proper escaping... should probably add something to the Readme about that. I forgot to do so when I submitted the plugin patches. I'll see about a PR. |
Thank you gentlemen for your excellent support! |
Hmm, nope.. seems like it just prints: A 1995 paper leaflet advertising IE's services (via brandnewretro. It doesn't seem to spot the syntax even after escaping the quote (with \ to be clear). |
Please try this line and tell me what happens
|
Nope, sorry; quote gets rendered okay (as it has been the past few iterations) but no link. It's as if the line is not being passed to the markdown parser or is not exiting it with the link correctly identified... |
Interesting. can you upload the exact image somewhere for me? I'll prep a fresh jekyll build and test with your image & tag. You can just load the image in here in the comments if you want. |
https://www.dropbox.com/s/y2mitrk7bh13zwg/Screenshot%202016-01-01%2010.34.34.png?dl=0 Surrounding code is now: Internet Éireann made some crucial decisions at the right time: they were betting on a growth market, which it was, and an ability to sweat their assets. In the mid-1990s ISP business, this meant running their modem pool "hot", i.e. having too few of them for the number of customers, as discussed above. It was a straightforward value-for-money consumer play, whose appeal was certainly based on cost, but also the even then staggeringly large array of services available to anyone at the other end of a dial-up connection. (See, for example, the below image, which shows a leaflet advertising Internet Éireann’s services.) {% fullwidth "assets/img/internet_eireann_feb_1995_p.jpeg" "A 1995 paper leaflet advertising IE's services (via http://brandnewretro.ie/2012/08/23/old-adverts-88-internet-eireann-1995/)" %} This leaflet advertises a number of wonderful facilities, the majority of which have now perished, or been swallowed up by the hypergrowth of the web in general: “File Transfer”, “Telnet”, “Archie”, “Gopher”, and so on. |
Thanks! I'll test right now on a fresh install. I'm curious why this isn't working. 😉 |
Ok, I was wrong, you usually don't need to escape anything. The Liquid plugins for Jekyll are intelligent enough that if you use double quotes, it auto-escapes single quotes. Or if you use single quotes, it should auto-escape double quotes. For example, using the following tag:
This is my result: http://fullwidthtest.surge.sh/test/ So the Liquid tags are working correctly, the text is rendering properly. However as you can see the captions are not clearing properly. They don't clear properly in any of the page layouts (page, post or full-width) |
And @niallrmurphy yes, if you correctly escape the double quotes in the href tag it should create a hyperlink for you:
Or you can use single quotes in the href tags, either way works great.
|
Understood, thanks! |
Here's what I think is a good fix, put this into your
Here's a preview: http://fullwidthtest.surge.sh/test/ using this tag:
|
Excellent, thanks! |
Cool, if this is fixed for you feel free to close the issue. I put in a pull request #26 to help fix this issue. |
Thanks Nick. I have merged the pull request into the master. I appreciate the help on this.
|
Thanks, and You're welcome! |
So, e.g. {% fullwidth 'blah/img/blah' 'Hi there this is a source' %} will just be printed as plain text.
The text was updated successfully, but these errors were encountered: