Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automatically prefix entity name with circadian_lighting_ #18

Closed
frenck opened this issue May 2, 2019 · 4 comments
Closed

Don't automatically prefix entity name with circadian_lighting_ #18

frenck opened this issue May 2, 2019 · 4 comments

Comments

@frenck
Copy link

frenck commented May 2, 2019

Please don't prefix generated entity_id's with circadian_lighting_, this is not how Home Assistant does this in general.

In my case, it screws with my naming schemes. e.g., I use a naming schema <domain>.<area>_<name>

When adhering to my scheme, the switch for my hall would end up being:

switch.circadian_lighting_hall_circadian_lighting 😔

@claytonjn
Copy link
Owner

Yes, I plan on making this change. My entities are all the same, with circadian_lighting at the beginning and end. I've only held out because I made the poor choice at the beginning and it would be a breaking change.

If I have enough time to make change #4 then I will definitely make the change then, as that would be equally breaking.

@pacobyte
Copy link

Have you had time to begin working on this change? I just installed Circadian Lighting today and was disappointed that the configuration's name: property worked differently than the rest of Home Assistant's integrations.

@claytonjn
Copy link
Owner

Unfortunately not, along with this change I also need to update the integration to add everything to the entity registry to allow for changing the entity_id. Really, though, I want to implement this breaking change along with #4 as that would also greatly enhance functionality, but that's a significant amount of work that I unfortunately don't have time for currently.

@ceesvanegmond
Copy link

@frenck 👍 +1

@frenck frenck closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants