Skip to content

Commit

Permalink
Merge pull request #61 from Crelde/master
Browse files Browse the repository at this point in the history
Change to alwaysHex
  • Loading branch information
clbrge committed Jul 16, 2023
2 parents 92ce1cc + 3227517 commit 5cbb7d9
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions src/stores.js
Expand Up @@ -39,9 +39,8 @@ const getWindowEthereum = () => {
}
}

// always get chainId as number
const alwaysNumber = (n) =>
Web3.utils.isHex(n) ? Web3.utils.hexToNumber(n) : n
// always get chainId as number EDIT: Always as hex
const alwaysHex = (n) => (Web3.utils.isHex(n) ? n : Web3.utils.toHex(n))

export const createStore = () => {
const { emit, get, subscribe, assign, deleteAll } = proxied()
Expand All @@ -53,7 +52,7 @@ export const createStore = () => {
}) => {
// console.log('switch1193Provider', { accounts, chainId }, get('web3'), get('eipProvider'))
if (!chainId) {
chainId = alwaysNumber(await get('web3').eth.getChainId())
chainId = alwaysHex(await get('web3').eth.getChainId())
}
if (!accounts) {
accounts = await get('web3').eth.getAccounts()
Expand All @@ -76,7 +75,7 @@ export const createStore = () => {

const accountsChangedHandler = (accounts) => switch1193Provider({ accounts })
const chainChangedHandler = (chainId) =>
switch1193Provider({ chainId: alwaysNumber(chainId) })
switch1193Provider({ chainId: alwaysHex(chainId) })
// TODO better error support ?
const disconnectHandler = (error) => switch1193Provider({ error })

Expand Down Expand Up @@ -138,7 +137,7 @@ export const createStore = () => {
return set1193Provider(provider, addressOrIndex)
init()
const web3 = new Web3(provider)
const chainId = alwaysNumber(await web3.eth.getChainId())
const chainId = alwaysHex(await web3.eth.getChainId())
let accounts = []
try {
// not all provider support accounts
Expand Down

0 comments on commit 5cbb7d9

Please sign in to comment.