Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi Claudio #24

Open
eiked opened this issue Nov 1, 2015 · 5 comments
Open

Hi Claudio #24

eiked opened this issue Nov 1, 2015 · 5 comments

Comments

@eiked
Copy link

eiked commented Nov 1, 2015

I'm working on the code,
hope to have improved it.
~eike

what's new?

  • refactored eval, void_eval etc
  • the eval methods now take a args:hash as an optional argument
  • those args are assigned before executing the cmd
  • add geterrmessage() to the exception message
  • add ".r" method (experimental) (inspired by the py client)

I'm not yet really satisfied with that.
I'd like to call R like a rpc.

~eike

@Kadrian
Copy link

Kadrian commented Nov 24, 2015

Hi Eike, I'm really interested in those features, especially getting error messages in the exception message. Is there a branch / fork of yours that I could check out?

@eiked
Copy link
Author

eiked commented Nov 30, 2015

Hi Claudio,
I'd like to forward my changes to you.
I'm not yet well versed how github works -- please excuse ;-)
Should I put my modifications on github as my patch first?

I currenlly have the patches local at me only,
and I don't want them to show them up as a fork anywhere in the public.
Because first of all, you should have a look at it.
And this is not a fork, this only a patch.

So I'm pretty new to github, and I've not got it, yet.

Well, one of my changes (days back now) was to refactor the eval error handling
so that I could make a second request to retrieve the error message,
ignoring any further errors on that error requesting request (to avoid infinteloop)

In the effect I can now much better display the errors,
actually retrieving the cause of the error and displaying it, aka returning it in the exception message.

And this actually helps a lot, when trying to debug requests from ruby to R.
Because before this was only: 'failed" but now I get the R error messages back,
nicely packed in the message of the Exception.

I'm still fiddeling with github.
this should not stop us.

You'll get my patches in your hands,

I worked at it, hope you'll like them.

I'm really looking forward to even better integrate R with ruby.
I could even imagine to integrate as a repl,
aka dropping from the pry repl into a R repl (done via r-serve)
to try out things interactively, from within a ruby repl.

I'm a big fan to make it easy first,
so we're not yet here to map all data structures from R to ruby (and vice versa)

I've also added an experimental module to mimic the integration like in python.
But this still lacks the references, so this is not yet done,
actually more like showing up what can be done with ruby ...

Looks like you need my patches,
ruby'R is us

@smartperson
Copy link
Contributor

FYI I opened a pull request 7 months ago. I think @clbustos has stopped working on this project.

@eiked if you have useful changes, go through the github documentation to fork this project, make your edits, (important) create new tests as necessary and run the current ones, and submit a pull request. That way your contributions won't get lost, and the future maintainer can integrate them.

@clbustos
Copy link
Owner

clbustos commented Dec 9, 2015

Hey, sorry for don't reply. I have a very tight schedule and I forgot to reply.
Please, fork with your changes, create new test and verify that all old ones work fine. Once that is done, I will merge and upload a new version

@narapon
Copy link

narapon commented Feb 6, 2016

@eiked I find the geterrmessage() to be an important feature. I hope this gets a pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants