Skip to content

Commit

Permalink
Adds safer regular expressions to avoid performance issues.
Browse files Browse the repository at this point in the history
Flagged by GitHub.
  • Loading branch information
jakubpawlowicz committed Mar 31, 2022
1 parent 9083e10 commit d89424d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions lib/reader/extract-import-url-and-media.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ var split = require('../utils/split');
var BRACE_PREFIX = /^\(/;
var BRACE_SUFFIX = /\)$/;
var IMPORT_PREFIX_PATTERN = /^@import/i;
var QUOTE_PREFIX_PATTERN = /['"]\s*/;
var QUOTE_SUFFIX_PATTERN = /\s*['"]/;
var URL_PREFIX_PATTERN = /^url\(\s*/i;
var URL_SUFFIX_PATTERN = /\s*\)/i;
var QUOTE_PREFIX_PATTERN = /['"]\s{0,31}/;
var QUOTE_SUFFIX_PATTERN = /\s{0,31}['"]/;
var URL_PREFIX_PATTERN = /^url\(\s{0,31}/i;
var URL_SUFFIX_PATTERN = /\s{0,31}\)/i;

function extractImportUrlAndMedia(atRuleValue) {
var uri;
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/is-data-uri-resource.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
var DATA_URI_PATTERN = /^data:(\S*?)?(;charset=(?:(?!;charset=)[^;])+)?(;[^,]+?)?,(.+)/;
var DATA_URI_PATTERN = /^data:(\S{0,31}?)?(;charset=(?:(?!;charset=)[^;])+)?(;[^,]+?)?,(.+)/;

function isDataUriResource(uri) {
return DATA_URI_PATTERN.test(uri);
Expand Down

0 comments on commit d89424d

Please sign in to comment.