Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem importing relative URL's so I had to do a bunch of debug.
Found the problem on line 267 - it needed "parsedUrl.pathname"
Here's stuff from the debug (so you can verify on your end)
root@testhost:
# cleancss -d --root http://jeffwalker.com/wp-content/themes/salient-child/ http://jeffwalker.com/wp-content/themes/salient-child/style.css?ver=4.1.1# cleancss --versionhttp://jeffwalker.com/wp-content/themes/salient-child/style.css?ver=4.1.1
Inlining remote stylesheet: http://jeffwalker.com/wp-content/themes/salient-child/style.css?ver=4.1.1
../salient/style.css
Inlining remote stylesheet: http://jeffwalker.com/salient/style.css
fonts/bebas-neue/stylesheet.css
Inlining remote stylesheet: http://jeffwalker.com/fonts/bebas-neue/stylesheet.css
Original: 28258 bytes
Minified: 23304 bytes
Efficiency: 17.53%
Time spent: 96ms
ERROR: Broken @import declaration of "http://jeffwalker.com/salient/style.css" - error 404
ERROR: Broken @import declaration of "http://jeffwalker.com/fonts/bebas-neue/stylesheet.css" - error 404
root@testhost:
3.0.10
inliner: { timeout: 5000, request: {} },
rebase: true,
relativeTo: 'http://jeffwalker.com',
root: '/root',
sourceTracker: { sources: [ 'http://jeffwalker.com/wp-content/themes/salient-child/style.css' ] },
warnings: [],
visited:
[ 'http://jeffwalker.com/wp-content/themes/salient-child/style.css',
'http://jeffwalker.com/salient/style.css' ],
afterContent: false,
shallow: false,
isRemote: true }
*** AFTER FIX ***
root@testhost:~# cleancss -d http://jeffwalker.com/wp-content/themes/salient-child/style.css -o jeff.css
Inlining remote stylesheet: http://jeffwalker.com/wp-content/themes/salient-child/style.css
Inlining remote stylesheet: http://jeffwalker.com/wp-content/themes/salient/style.css
Inlining remote stylesheet: http://jeffwalker.com/wp-content/themes/salient-child/fonts/bebas-neue/stylesheet.css
Original: 248065 bytes
Minified: 202793 bytes
Efficiency: 18.25%
Time spent: 353ms