Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove Node.js 7 and add 8 and 10. #1071

Merged
merged 1 commit into from
Nov 12, 2019
Merged

CI: Remove Node.js 7 and add 8 and 10. #1071

merged 1 commit into from
Nov 12, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Apr 8, 2019

Also remove the obsolete sudo: false from Travis.

Also remove the obsolete `sudo: false` from Travis.
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 8, 2019

BTW we could probably use Travis for Windows testing too later, and see how it goes.

@jakubpawlowicz
Copy link
Collaborator

Good call 👍, we probably should support v12 nowadays too?

@jakubpawlowicz jakubpawlowicz merged commit fce305b into clean-css:master Nov 12, 2019
@XhmikosR
Copy link
Contributor Author

Yeah, but when I made the PR v12 wasn't LTS :)

IMO you should drop anything less than 8 and grab the chance to use modern features

@XhmikosR XhmikosR deleted the xmr-ci branch November 12, 2019 15:19
@jakubpawlowicz
Copy link
Collaborator

Good idea 👍

@XhmikosR
Copy link
Contributor Author

I'm gonna take a stab at it in the next days, but please try to fix the Windows backslashes issue in source maps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants