fix proxy issues on https @imports #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to have some kind of integration test here, like ones in https://github.com/jakubpawlowicz/clean-css/blob/master/test/protocol-imports-test.js#L552 ? |
|
@jakubpawlowicz Sure thing, but as you have not had decided for one of the pull requests yet it would have been a waste of time to already add tests ;) |
wzrdtales
force-pushed
the
httpsFixw/oRequest
branch
2 times, most recently
from
7741a39
to
964f02a
Compare
|
It's all good! Would you mind squashing all 3 commits into one? Then I'll merge the PR. |
When an @import used a https url, the false protocol was tried to be used for the http proxy. fixes clean-css#741
wzrdtales
force-pushed
the
httpsFixw/oRequest
branch
from
9a26398
to
9a61d36
Compare
|
I don't see any sense in that but okay, here you go. |
|
It's to keep tests and code together so at some point it'd easier to figure out why this change was made. Thank you! |
|
ok, generally rewriting the git history is a bad thing though. In which version is this going to be published? |
|
Aiming at 3.4.11 tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an @import used a https url, the false protocol was tried to be used for the http proxy.
fixes #741