CPLAT-8040 Implement/Expose useRef Hook #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # example/test/function_component_test.dart # lib/hooks.dart # lib/react_client/react_interop.dart # test/hooks_test.dart
# Conflicts: # example/test/function_component_test.dart # lib/hooks.dart # lib/react_client/react_interop.dart # test/hooks_test.dart
sydneyjodon-wk
changed the base branch from
5.3.0-wip
to
CPLAT-8035-useeffect-hook
sydneyjodon-wk
changed the base branch from
CPLAT-8035-useeffect-hook
to
5.4.0-wip
greglittlefield-wf
requested changes
Jan 14, 2020
lib/hooks.dart
Outdated
| /// final input = useState(''); | ||
| /// final inputRef = useRef(); | ||
| /// final prevInputRef = useRef(); | ||
| /// final prevInput = prevInputRef.current; |
There was a problem hiding this comment.
These variables are named pretty similarly, which makes it a little hard to tell what's going on. I think further distinguishing them and also adding some typing to the refs would help:
final inputValue = useState('');
final inputRef = useRef<InputElement>();
final prevInputValueRef = useRef<String>();
useEffect(() {
prevInputValueRef.current = inputValue.value;
});
return react.Fragment({}, [
react.p({}, ['Current Input: ${inputValue.value}, Previous Input: ${prevInputValueRef.current}']),
react.input({'ref': inputRef}),
react.button({'onClick': (_) => inputValue.set(inputRef.current.value)}, ['Update']),
]);
|
Looks like there are merge conflicts on this one now too after merging another PR 😅 |
# Conflicts: # example/test/function_component_test.dart
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support useRef hook in
react-dart.Changes
useReffunction.initUseRefconstructor to theRefobject.currentproperty ofRef.Please review: @kealjones-wk @aaronlademann-wf @greglittlefield-wf @joebingham-wk