-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baro - alt hold issue #1926
Comments
Did you actually cover the baro with foam? |
Yes, and protected from light, Baro reads as seen on the logs are very accurate |
same issue with NAZE32 & firmware v1.12 |
Same here.. Naze32 Rev 6, 1.12. MW-rewrite. ALT hold is not good. I was fairly close with 1.11, but this one is not good |
Just out of interest, this evening, I set all my ALT PID values to 0. Set up stable hover, then flicked my ALT-HOLD switch. At first, it began to drop slowly, then climbed rapidly to roughly where hover was. Then I got a blip and it shot up a couple of feet. Then a long burst of throttle, so I switched the baro off. I was under the impression that at 0 PID values, switching the baro on would essentially do nothing? |
Tried again on stock ALT / VEL PID's I switch the Baro on, and I'm sure I don't touch the throttle, but if you check RCcommand (Thr) it's all over the place until baro's turned off. I'll try again as soon as I get some daylight |
I have the same issue with altitude hold on mine. It starts to erratically jump/fall all the time. I've got a plastic cover over the Naze32 with a big piece of open-cell black foam over the barometer. So I think it's well shielded from light and wind. |
It's totally erratic. Mine is in a 3D printed housing with foam on the baro, and (I think) the black box shows very little noise on the baro trace. As soon as I throw the switch, my rccommand trace goes wild. Is that actually "rc input" or what the flight controller is sending to compensate? |
Probably ACC noise problem. Balancing props may help. You may try setting |
Ok, first day in a long time I've been able to properly test fligh, bad luck I only one one lipo ready (weather forecast was SO wrong).
All in all, this was way better, and certainly can be qualified as working, but I intend to do much more test tomorow |
https://github.com/cleanflight/cleanflight/blob/master/src/main/flight/altitudehold.c#L193 IMO it's 35cm/s for 100cm altitude delta Main problem is that noise in accZ is almost 5G peak-peak. No filtering will remove it and estimated vertical speed is way off. Another strange thing is that acc data are updated only at 100Hz, remaining positions are somehow interpolated: |
I've been comparing my two dumps... 1.11 and 1.12. These fields are different... set rc_smoothing = ON (Set as OFF in 1.12) I can see the below acc_lpf in the manual for 1.11 and 1.12. There is no entry in the 1.12 manual for acc_cut_hz?? Has this replaced lpf factor? set acc_lpf_factor = 4 (1.11 value. Doesn't exist in the 1.12 dump) I might restore 1.11 and try my ALT hold. |
Main problem is that TASK_ACCEL is run at 100Hz. This will cause aliasing of any ACC frequency over 50Hz. LEVEL and HORIZON modes are probably affected too, but most samples are discarded (only 0.9-1.1G is used for leveling reference), so time constant is probably much longer than expected. You may try recompiling with higher ACC update (https://github.com/cleanflight/cleanflight/blob/master/src/main/scheduler_tasks.c#L62), try 1000 or 2000. |
Hi Ledvinap, I'm not able to compile sadly. I did however do a test by using stock ALT PID's at CF 1.11 and here is my blackbox. ALT hold works, albeit needs tuning slightly. Flight hardware is exactly the same... motors, props (same - they're well balanced) and battery. Something changed in 1.12 to affect this? |
Hi, I use Naze32 full and i tried to configure PIDs for ALT Hold too, and... was impossible, i have foam covering naze32 and i tried a lot of combinations of ALT and VEL pids, but i havent luck, teorically ALT is for configure Baro and Vel is for vertical speed. Anyone know how to configure correctly or is impossible in 1.12? |
Related to Issues #1946 and #1949 ? |
@lainchir yes, it appears that CF is going down the road of becoming a racing-oriented firmware. Sometimes this leads to favoring acro-mode performance and sacrificing quality of self-leveling, altitude hold etc. |
That would be a real shame if that was the case. |
digitalentity your firmware is based in cleanflight, have the same problem actually or we can migrate to your firmware? In my city there is a lot of people that have naze32 and sp racing f3, but look for more relaxed flight. For races often use betaflight. |
@ghostsharp |
Hi All, after some very important internal code changes that really need doing for 1.13.0 we can turn our attention back to the non-miniquad racing scene. Yes, there has been a certain drive in that area recently, mainly due to @borisbstyle recent developer availability however I am keenly aware that people want to more than just fly FPV mini quads. Merging the iNav code back into cleanflight will be a priority. |
Hi, I was afraid you took Cleanflight towards being a race-only platform.
Good to know I was wrong! Thanks for the access! 😃
Regarding this issue. In iNav this issue is not existent as the whole
position in 3D space is estimated with great accuracy. I don't think we
should concentrate on fixing the piece of code that's going to be replaced
altogether.
After 1.13 I'll start merging small things of iNav to CF, but we'll need to
consider the ways of freeing up space for main part.
|
May be we should really focus on the more capable targets for the NAV features. It does not make sense in my view to limit main functionally to fit this into the F1 MCU's. May be the F1 should keep good flight performance and will be even good for racing but navigation and may be autonomous flying will be done on F3 and F4 targets only. They will provide more memory and CPU power for this to sture all the additional code/configuration and run more complex algorithms. Adding and removing features specific for individual targets work quite well in my view. |
@MJ666 it depends on the definition of main functionality. |
The solution may be having an online firmware building environment. You select what features you need and get the customised firmware. |
Have issue with BMP280 in AltHold mode. In AltHold my quad start "jumping" up and down +-5 meters. PIDs changes had no effect. In Cleanflight Configurator i see smoothed altitude data but looks like in flight controller used RAW data from sensor. I'am connected with EZ-GUI from my phone. It shows me raw data from baro and spikes in graph look like quad jumps. Flight controller: Naze32 rev.6 |
@lechak Could you try with Cleanflight 1.13.0? The accelerometer issue has been fixed there @digitalentity good to hear that, I would love to see RTH with Althold and auto landing in Cleanflight 1.14, never quite managed to set up throttle landing (probably because throttle controls acceleration force and not velocity) |
Baro issues was fixed since 1.13 RC1. Now i'am fly on 3862_a645e2c_travis build. No time to reflash to stable release. But all fine now. |
…er-processing-decoupling Rangefinder processing decoupled from reading
I've been trying to adjust my alt hold on SPF3 Mini, but I'm facing s strange issue. Blackbox log is here : http://users.skynet.be/fa565566/LOG00001.TXT
Ignore the first half of the log, it is in my garden with trees all allround, needed to fing a safe spot. I'm iddling at arround 16/17m, all seems fine, then suddenly, it starts gradually loosing altitude with no appararent reason, nor reaction to the alt loss. Baro reads match what I saw
VEL PID : 5
ALT PID : 9 - 0 - 1
Does anybody know how to log debug1 to 3 values on blackbox ? I could compile an hex with ALT_HOLD_DEBUG
The text was updated successfully, but these errors were encountered: