Prepare for 1.13.0 release

[martinbudden]

TODO

1. Update release notes with summarised change log.
2. Post links on facebook and twitter only when release notes are completed.
3. Wait for RC1 bug reports and make a list of them here.
4. Wait for RC2 reports and make a list of them here.
5. Release final code (no RC3).
6. Update configurator.

Release Candidate 1 (RC1) feedback

1. Release notes should mention that PID LUX_FLOAT has had its settings scaled to the same values as MWREWRITE so that users can change between LUX_FLOAT and MWREWRITE without changing their PID values.
2. Release notes should mention that on CC3D PPM has been moved from pin 3 to pin 8.
3. Release notes should mention that Cleanflight has a new safety feature - it won't arm if the processor is overloaded. This normally only effects F1 boards (e.g. Naze, Flip and CC3D). If there is a problem with arming with one of these boards users should switch to the MWREWRITE PID.
4. Issue air mode not showing as active via MSP #2156 - air mode not lighting up in Mode in v1.13.0-RC1, PR Implement BoxAirMode flag in MSP_STATUS #2159 fixes
5. PR Fix warnings #2150, fix warnings in build
6. PR USB-VCP gcc 5.3 fix #2120, USB-VCP gcc 5.3 fix
7. PR Cleanup leds #2139, Cleanup leds
8. PR Fix dummy function prototype #2141, Fix dummy function prototype
9. PR Fix for DTerm scaling in pid_luxfloat to match pid_mwrewrite. #2178, fixes issue Scaling of PID_LUXFLOAT to match PID_MWREWRITE is incomplete #2177
10. PR Fixed handling of rcCommands[] in main pid loop. #2176, fixes issues uncontrollable oscillating throttle with sbus receiver in CF 1.13? #2165 and Headfree Mode - Tracks Orientation Incorrectly - v1.13 RC1 #2149
11. PR Added doc for building on Fedora linux #1090, (documentation only) instructions on building on Fedora linux (this has been hanging around for 11 months).

DONE

1. Bug fix - CC3D - PPM glitch fix, PR CC3D - PPM glitch fix #1790
2. Bug fix - Changed TASK_ACCEL desiredPeriod to 1ms, PR Changed TASK_ACCEL desiredPeriod to 1ms. #2076
3. Bug fix - Fix G-Tune, PR Fix G-Tune #2081
4. Documentation - Update of PID documentation to reflect PID_LUXFLOAT changes, PR Update of PID documentation to reflect PID_LUXFLOAT changes #2059
5. Test code - Updates for Junit xml unit test results and test coverage, PR Updates for Junit xml unit test results and test coverage.  #1693 (This has been hanging around for ages and @AndersHoglund has rebased it 4 times). We need to encourage test code related PRs.
6. Cleanup - Cleanup - further tidying of config.c PR Cleanup - further tidying of config.c #2077
7. Review issues/PRs assigned to milestone v1.13.0 - https://github.com/cleanflight/cleanflight/milestones/1.13.0 and reschedule or add to this task.

1 and 2 are in betaflght.
We keep getting issues raised which are related to 2.
3 is a simple 3 line fix.
4 and 5 are entirely safe, since they are documentation and test code related.
5, while not essential, is a very good 'nice to have' and is further cleanup related to PR #2034 - Configuration storage - templates + improvements

Other PRs

1. MSP Mem Interface Msp mem interface #2075
2. Documentation - PR Update documentation for MOTOLAB target #2102 Update documentation for MOTOLAB target
3. Documentation - PR Chapters missing from Manual.pdf when there are no \n before '#SectionName' #2100 Chapters missing from Manual.pdf when there are no \n before '#SectionName'
4. Documentation - PR irc channel: don't ask and leave! :-) #2085 irc channel: don't ask and leave! :-)
5. Target specific - PR Add MPU6000 code to MOTOLAB target #2099 Add MPU6000 code to MOTOLAB target
6. Cleanup - PR Fixed const correctness of gpioInit functions. #1798 Fixed const correctness of gpioInit functions
7. Cleanup - PR Reduced target specific #ifdefs in config.c #2114 Reduced target specific #ifdefs in config.c
8. Cleanup - PR Split mixer.c into mixer.c and servos.c #2125 Split mixer.c into mixer.c and servos.c
9. Cleanup - PR Cleanup of acc device drivers extern usage #2117 Cleanup of acc device drivers extern usage
10. Cleanup - RP Cleanup of gyro_sync.c #2116 Cleanup of gyro_sync.c (sorry the late addition, I thought this was already on the list)

PRs assigned to v1.13.0

1. I suggest PR adding support for Multiplex SRXL V2 #1538 (adding support for Multiplex SRXL V2) is deferred to 1.14.0 - this needs a cleanup to do properly. (@martinbudden)
2. I suggest PR Configuring data with TX and oled menus #1654 (Configuring data with TX and oled menus ) is deferred to 1.14.0. I really like this PR, but it needs a bit more work and review. (@martinbudden)
3. I suggest PR https://github.com/cleanflight/cleanflight/pull/1688/files (target file clean up) is deferred to 1.14.0. We will be revisiting the target files as part of PR IO and EXTI driver #1421 and EXTI driver) anyway. (@martinbudden)

Postponed

1. new CLI "beeper" command  #2112 new beeper configuration

[mrzed72]

Please bugfix:
#1780
#2079

[martinbudden]

@mrzed72 , both issues #1780 and #2079 should be fixed by PR #2076, item (2) in my list above.

[hydra]

great, I'll crack on with this in the next day or so. Really important to get the 1.13.0 and latest development configurator pushed out to the world, especially for USB VCP users.

I must say I've been flying v1.13.0 for a while now on a variety of aircraft: wings, micro, mini 180/210 and large 450 quads. I need to update my Tri copter and give that a good fly after merging the above.

[hydra]

@martinbudden i merged 1 to 5. 6 needs a change (#2077).

The MSP cleanup PR should be merged for 1.13.0 IMHO. #2075

[hydra]

Someone (@DigitalEntry) needs to fix warnings being generated by inclusion of new mavlink code from #806

[martinbudden]

@hydra, the problem that @ledvinap mentions in #2077 is a pre-existing one (as he says), not a problem that the cleanup introduced. So the cleanup code should be merged.

Having said that, the setting is clearly wrong, so I have just removed it. Users can now set it manually if required. We can set the inverted as a default in the appropriate receivers at a later date, when we have the information as to which receivers it applies to.

[digitalentity]

@hydra cleanup pending. I prefer to have things atomic - make it working and supported first. Optimise and cleanup later. I'm also stripping down the library to reduce the source code size.

[martinbudden]

@digitalentity , a minor quibble, but the whitespace in your MAVLink code is not consistent - sometimes tabs are used and sometimes spaces. Can you convert it all to spaces, as per Cleanflight standard?

[digitalentity]

@martinbudden That's MAVLink library code that has tabs and spaces mixed up. I'd like to avoid changing 3-rd party code.

[martinbudden]

@digitalentity , I hadn't realised that. I agree, it's good to avoid changing 3rd party code.

BTW, is there a plan to merge iNav into Cleanflight for version 1.14.0 ?

[digitalentity]

@martinbudden I'm going to start submitting PRs for INAV-specific features after 1.13 gets released.

[martinbudden]

@digitalentity - brilliant. I look forward to seeing this.

[digitalentity]

@martinbudden I doubt INAV will make it into CF for version 1.14 - too much to merge, but some of the changes (IMU, GPS driver) will likely be merged. 😄

[martinbudden]

@hydra , @ledvinap I didn't put the MSP cleanup PR #2075 on the list because I assumed it was a done deal. Yes, of course this should go in.

On reflection, it would also be a good idea to get AlienFlightF3 V2 support PR #1638 in as well - since this is a localised change and won't jeopardise the release.

[martinbudden]

@hydra , a late entry: PR #2108 - Added PIDs to OLED display profile page. Added TASKS page.

This change is localised to the display code and so "safe".

Having the PIDs on the profile page is really useful (especially since they are now standardised between LUX and MWR). And the TASKS page is useful to check if changes to looprates etc have caused processor bandwidth problems.

[hydra]

merged #2108 and 6 (#2077) now.

[hydra]

@martinbudden I updated the task description. I've rescheduled a few issues, will continue to review the list and see what I can get done.

[martinbudden]

@hydra , great.

It would be good if you could merge in PR #2109 , this tidies the makefile a bit so that the targets are handled all in one place.

[MJ666]

Have rebased #1638 again today.

[hydra]

@MJ666 thanks. Will look now.

[hydra]

added * Code review and test#2112 to task.

@Pierre-A @ledvinap @martinbudden - can you help? If so comment on the issue when you start looking so that work is not duplicated.

[hydra]

@MJ666 on second thoughts I will look when i get a chance, it's 00:19 here now and I'm tired! Enough for tonight.

[martinbudden]

@hydra , see PR #2113. This saves about 850 bytes of ROM on CC3D by limiting the max number of motors to 6 (there are only 6 PWM pins on CC3D boards anyway, so this shouldn't cause a problem for many people). This should provide enough to allow PR #2112 to build - Travis build says CC3D overflowed ROM by 210 bytes. [I haven't actually tested the 2112 build with my PR though.]

[I've got a few more ROM savings in my back pocket if we need them for any of the other PRs]

[skaman82]

It would be also nice if some new LED functionality could make it in the new release. This has been requested long time ago and @gaelj has finally made this happen:

• Selectable Armed Colors (and other fixed colors)
#2053

• Support LED cmds GPS, RSSI & Blink
#2101
cleanflight/cleanflight-configurator#379

The "Support LED cmds GPS, RSSI & Blink in configurator" PR is not quite ready yet, but I think @gaelj will finish this quickly.

[hydra]

@martinbudden PR's suggest to defer have been deferred.

[hydra]

@martinbudden #2098 (blackbox enhancements) isn't ready. there's discussion still.

[hydra]

deferred #2109 to 1.14.0

[hydra]

@martinbudden see #2117 (comment)

[hydra]

#2117 merged, flight tested on CJMCU and EVO.

[hydra]

ok, only two outstanding items remain:

SPRacingF3MINI Parallel PWM support #2110
and new beeper configuration #2112

I'm done for tonight, suggest if someone has time to review #2112 and test. I will work on #2110 tomorrow and then tag master for v1.13.0-RC1

[martinbudden]

Almost there! Great work @hydra

[skaman82]

@hydra #2101 is also good to go now

[hydra]

ok, all done. couple of warnings in master to fix.

[hydra]

done, see 1e14fd7

[digitalentity]

@hydra you can merge #2107 for now - it reduces number of source files and has a temporary fix for mavlink warnings.

[hydra]

@digitalentity for RC2, yes. @martinbudden can you update the topic description to keep track of bugs raised against RC1 so we all know what to do for RC2 ?

No new features accepted until v1.13.0 is FINAL. Bug fixes to master only.

[digitalentity]

@hydra great! I have a bunch of things for next 1.14 relese.

[martinbudden]

@hydra , I couldn't think of a better name for topic, since it's still about preparing for the v1.13.0 release. I've added a section Release Candidate bug reports though.

[hydra]

Release notes updated.

https://github.com/cleanflight/cleanflight/releases/tag/v1.13.0-RC1

[hydra]

Links posted on social media:

https://twitter.com/Cleanflight/status/730697489582592001

https://www.facebook.com/permalink.php?story_fbid=855083651268087&id=582474325195689

Please share!

[hydra]

Can someone create an issue in the configurator repo and collate PR's they feel should be merged?

[hydra]

I've just pushed out a small release of the configurator v1.2.2 with the current development head that I've been using for quite a while now. Mainly so that VCP users get the benefit. Now we can concentrate on configurator v1.3.0.

[hydra]

want to merge in #2139 but there is an issue with the blink code.

see #2139 (comment)

[hydra]

@martinbudden thanks for collating the RC bug report issues. much appreciated. you're doing awesome work.

[martinbudden]

@hydra , glad my work is appreciated. It would make things easier for me if you gave me permissions to change the labels on issues and PRs, and also to close issues (there are lots of "support questions" issues that can be closed). There are also quite a few forgotten PRs that could do with relabelling.

[hydra]

@martinbudden sure, will do (if i can work out how..)

[hydra]

RC2 is out now.

Thanks everyone!

The plan now is to wait for RC2 bug reports and release final code on 6/6/2016.

[martinbudden]

@hydra , thanks for adding me as a Cleanflight member. I've made an initial pass through the PRs and some of them labels. Two questions:

1. There are quite a few documentation PRs outstanding. Is it OK for me to merge these in?
2. There are quite a few minor enhancements, including a few old ones that seem to have been lost in the large number of PRs. Is it OK for me to assign these to the 1.14 milestone? (Of course on further examination they may be bumped to a later milestone, or dropped entirely)?

[hydra]

1. with regards to documentation PRs ensure that all links are relative before merging (or fix locally via another comit locally before merging). Inform original authors via commit links any changes made so they can contribute better in the future.
2. With regards to other minor enhancements and milestone. Assign minor enhancements to 1.15.0, not 1.14.0.

I have opened #2211 to discuss 1.14.0 and the future.

[hydra]

Final is out (Since 6/6/2016). It was late, i didn't have time to update this and have been working on the OSD code all week.

Thanks everyone who contributed to this release!