Increase MSP and serial separation #2456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this really usefull? There is always only one possible handler for packets received over MSP and linker can easily resolve correct function for FC/OSD case (with error checking). Using indirection will only complicate things ... |
martinbudden
pushed a commit
to martinbudden/cleanflight
that referenced
this pull request
Feb 27, 2017
…i_spektrum_bind_pin Re-add Spektrum bind pin for SPRACINGF3MINI / TINYBEEF3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases separation between MSP and serial code by avoiding hardcoded
mspProcessCommandinmsp_serial.c. Instead a function pointer is passed intomspSerialInit.Only done for the
MSP_SERVERside, but a similar thing could be done for theMSP_CLIENT.@hydra - what do you think?