Change cleanlab version in Image Tutorial #138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 87.29% 86.89% -0.40%
==========================================
Files 12 11 -1
Lines 968 908 -60
Branches 175 166 -9
==========================================
- Hits 845 789 -56
+ Misses 104 103 -1
+ Partials 19 16 -3
Continue to review full report at Codecov.
|
|
need to fix collab version before we merge |
weijinglok
force-pushed
the
fix-img-tut
branch
4 times, most recently
from
6ee01b6
to
f53f66e
Compare
| @@ -48,6 +48,33 @@ jobs: | |||
| - name: Install dependencies | |||
| run: python3 -m pip install -r docs/requirements.txt | |||
|
|
|||
| - name: Find and replace "%pip install cleanlab" with master branch in .ipynb files | |||
| if: ${{ github.ref_type == 'branch' }} | |||
There was a problem hiding this comment.
will this work for when we merge PRs into master also?
There was a problem hiding this comment.
Yes, it should. It may look a little odd because there isn't an if...else statement here, so it's just 2 separate if statements - one for when the doc CI is triggered by a push to the master branch, another when it's triggered by a newly published release.
In pseudocode, the above-highlighted code snippet does the following:
- If it's triggered by a push to a branch, i.e. the
masterbranch in thecleanlab/cleanlabrepo AKA our production repo - find
%pip install cleanlab # for colabin the.ipynbfiles and replace them with pip installing a specific commit hash of cleanlab. For example, if the doc build is run in thecleanlab/cleanlabrepo and the merging commit hash isabc123, then the replacement will be:
%pip install git+https://github.com/cleanlab/cleanlab.git@abc123
if this is unnecessarily specific, setting it to download to a specific branch would work too, e.g. something like:
%pip install git+https://github.com/cleanlab/cleanlab.git@master
This PR introduces:
cleanlab's latest API (AKA the upcoming v2.0.0 API)gh-pages.yaml) to dynamically install different versions ofcleanlabin the .ipynb notebooks based on whether it is triggered by a push tomasterbranch or a new release.cleanlab-docsrepo.cannot import name 'escape' from 'jinja2'issue.