Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NumPy deprecation warning #142

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

anishathalye
Copy link
Member

np.long was deprecated in NumPy 1.20, and this was making the test output noisy with deprecation warnings. This patch replaces the type with np.int32 (the labels are 0--9).

`np.long` was deprecated in NumPy 1.20, and this was making the test
output noisy with deprecation warnings. This patch replaces the type
with `np.int32` (the labels are 0--9).
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #142 (0a6b55b) into master (9a3eb36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files          12       12           
  Lines         968      968           
  Branches      175      175           
=======================================
  Hits          845      845           
  Misses        104      104           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a3eb36...0a6b55b. Read the comment docs.

Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge after #141

@jwmueller jwmueller merged commit dac3d12 into cleanlab:master Mar 28, 2022
@anishathalye anishathalye deleted the numpy-deprecation-warning branch April 7, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants