Remove unnecessary version warning #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 87.64% 87.56% -0.09%
==========================================
Files 12 12
Lines 1028 1021 -7
Branches 191 189 -2
==========================================
- Hits 901 894 -7
Misses 104 104
Partials 23 23
Continue to review full report at Codecov.
|
This was used to skip e.g. importing PyTorch on some tests. However, PyTorch supports all versions of Python that Cleanlab supports, so there's no need to issue this warning. Furthermore, having this kind of code in our codebase increases maintenance burden and contributes to user frustration. If we mark a version of some library as unsupported, but the library adds support for it in the future, there's no way users can use the two packages together without waiting for us to push a new version of cleanlab that marks that it's compatible and then switching to the new version, which may be painful for unrelated reasons. It's better to not have these kinds of checks; if users are using a version of Python that's unsupported by some other library that they want to use, that's not our problem, and they'll have issues installing or importing it and figure it out themselves. This patch also removes mentions of Python 2.
anishathalye
force-pushed
the
version-warning
branch
from
25ca7f9
to
332a4cf
Compare
jwmueller
approved these changes
Apr 3, 2022
cgnorthcutt
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
LGTM. We may have future dependencies requiring version warnings in the future, but I see no need to keep this code around while it is not at all in use or plans to be in use for the foreseeable future.
- Effectively we are saying that we will support all versions of python 3.6 and up and if you use pytorch or external libraries that don't support a version of python that cleanlab, supports, this will fail and you'll get a generic warning that you need to figure out. Overall, seems okay given that most libraries we interact with support similar versions than we do. It certainly makes the code a lot cleaner :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used to skip e.g. importing PyTorch on some tests. However, PyTorch supports all versions of Python that Cleanlab supports, so there's no need to issue this warning. Furthermore, having this kind of code in our codebase increases maintenance burden and contributes to user frustration. If we mark a version of some library as unsupported, but the library adds support for it in the future, there's no way users can use the two packages together without waiting for us to push a new version of cleanlab that marks that it's compatible and then switching to the new version, which may be painful for unrelated reasons. It's better to not have these kinds of checks; if users are using a version of Python that's unsupported by some other library that they want to use, that's not our problem, and they'll have issues installing or importing it and figure it out themselves.
Note: this patch doesn't remove the version warnings in the fastText-related code because #161 deletes that code.