Add CI check that .ipynb outputs are empty #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserving the output cells in Jupyter notebooks that are checked in to this repo bloat the repo size, and keeping the output is not necessary because the notebooks are run as part of the CI for producing docs. For example, in cleanlab#165, the `audio.ipynb` is 112K (and now part of the repo history forever), while clearing the output cells reduces that size down to 24K. I suspect that Git's delta compression will also work better without the output cells there as we make changes to the notebook. Also, the diffs will be more readable.
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 12 12
Lines 1028 1028
Branches 194 194
=======================================
Hits 901 901
Misses 104 104
Partials 23 23 Continue to review full report at Codecov.
|
jwmueller
reviewed
Apr 5, 2022
| @@ -358,7 +358,7 @@ | |||
| "hash": "ced20e3e49bb4fa4ce8ad38f8f2535b7fc4c39b2b89554502b5dbdad1ad67eda" | |||
| }, | |||
| "kernelspec": { | |||
| "display_name": "Python 3.10.0 64-bit", | |||
| "display_name": "Python 3 (ipykernel)", | |||
There was a problem hiding this comment.
just highlighting this in case it's unintentional
jwmueller
reviewed
Apr 5, 2022
| @@ -372,7 +372,7 @@ | |||
| "name": "python", | |||
| "nbconvert_exporter": "python", | |||
| "pygments_lexer": "ipython3", | |||
| "version": "3.8.10" | |||
| "version": "3.9.10" | |||
There was a problem hiding this comment.
just highlighting this in case it's unintentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168