Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check examples are found by cleanlab #172

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

weijinglok
Copy link
Contributor

@weijinglok weijinglok commented Apr 5, 2022

Add test to check that highlighted examples are found by cleanlab's find_label_issues in the tutorials.

  1. A mockup is available here - visually should have no differences from how it already is.
  2. An example of a failed build (i.e., checking an index that doesn't exist) is available here.
  3. Examples of successful builds are available here and here.

Commits were not squashed for traceability and audit. Please squash them before merging.

@weijinglok weijinglok added this to the Cleanlab 2.0 milestone Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #172 (c7ee174) into master (dcdb890) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   87.64%   87.65%   +0.01%     
==========================================
  Files          12       12              
  Lines        1028     1021       -7     
  Branches      194      192       -2     
==========================================
- Hits          901      895       -6     
  Misses        104      104              
+ Partials       23       22       -1     
Impacted Files Coverage Δ
cleanlab/internal/util.py 100.00% <0.00%> (ø)
cleanlab/example_models/mnist_pytorch.py 99.27% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdb890...c7ee174. Read the comment docs.

@weijinglok weijinglok marked this pull request as ready for review April 5, 2022 23:38
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jwmueller jwmueller merged commit 7247b09 into cleanlab:master Apr 6, 2022
@weijinglok weijinglok deleted the clean-tuts branch April 6, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants