Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various tutorial improvements #173

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Various tutorial improvements #173

merged 4 commits into from
Apr 6, 2022

Conversation

jwmueller
Copy link
Member

Another round of many tutorial improvements such as:

  • Not having weird reshape in forward pass of MNIST ConvNet (also verified this works with the LearningWithNoisyLabels).
  • Removing seemingly unnecessary TF logging suppression line in audio tutorial
  • Moving the hidden tests to the end of tutorials and add tests to ensure LNL improves the model accuracy.
  • Language and code improvements throughout tutorials.

Apologies for making PR from branch, my fork's master branch is occupied by open PR in limbo (was made from plane with bad internet)

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #173 (09bbf75) into master (7247b09) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files          12       12           
  Lines        1021     1021           
  Branches      192      192           
=======================================
  Hits          895      895           
  Misses        104      104           
  Partials       22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7247b09...09bbf75. Read the comment docs.

Copy link
Contributor

@weijinglok weijinglok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good! just one comment to be addressed!

docs/source/tutorials/audio.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@weijinglok weijinglok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jwmueller jwmueller merged commit a3bac68 into master Apr 6, 2022
@jwmueller jwmueller deleted the tutorialfixes branch April 7, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants