-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple fix to Issue 158 (and potentially other issues) #178
Conversation
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 87.25% 87.37% +0.12%
==========================================
Files 12 12
Lines 1036 1038 +2
Branches 198 198
==========================================
+ Hits 904 907 +3
Misses 106 106
+ Partials 26 25 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I rebased onto c4e8462. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summarizing discussion offline: decided to skip warning in this situation.
LGTM.
Fixes #158
A simple fix to clip the diagonal confident joint so that it avoids columns entirely of zero and always requires one correctly labeled example in every class.