Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple fix to Issue 158 (and potentially other issues) #178

Merged
merged 12 commits into from
Apr 6, 2022

Conversation

cgnorthcutt
Copy link
Member

@cgnorthcutt cgnorthcutt commented Apr 6, 2022

Fixes #158

A simple fix to clip the diagonal confident joint so that it avoids columns entirely of zero and always requires one correctly labeled example in every class.

  • This is the lowest-level place where the confident joint is computed. The fix (should) trickle to all downstream use cases.
    • In your review, consider if this is the case.
  • this PR reduces the warnings in our tests by half

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #178 (afad588) into master (c4e8462) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   87.25%   87.37%   +0.12%     
==========================================
  Files          12       12              
  Lines        1036     1038       +2     
  Branches      198      198              
==========================================
+ Hits          904      907       +3     
  Misses        106      106              
+ Partials       26       25       -1     
Impacted Files Coverage Δ
cleanlab/count.py 94.96% <100.00%> (+0.07%) ⬆️
cleanlab/filter.py 91.77% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e8462...afad588. Read the comment docs.

Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishathalye
Copy link
Member

I rebased onto c4e8462.

Copy link
Member

@anishathalye anishathalye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summarizing discussion offline: decided to skip warning in this situation.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of zero entries in true_labels_class_counts
3 participants