bug fixes and jupyter notebook support added #212
Conversation
|
Output of
|
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 95.48% 95.19% -0.30%
==========================================
Files 12 12
Lines 909 915 +6
Branches 180 184 +4
==========================================
+ Hits 868 871 +3
- Misses 15 18 +3
Partials 26 26
Continue to review full report at Codecov.
|
cleanlab/internal/util.py
Outdated
| shell = get_ipython().__class__.__name__ | ||
| if shell == "ZMQInteractiveShell": | ||
| display(df) # Jupyter notebook or qtconsole | ||
| elif shell == "TerminalInteractiveShell": | ||
| print(df) # terminal, not notebook | ||
| else: | ||
| print(df) # something else, but not notebook |
There was a problem hiding this comment.
An alternative could be: just display(df) in L460 and delete these extra checks. They anyway just goto L470, which would happen anyway if try clause fails.
I ask because not sure if ZMQInteractiveShell is overly limiting. Maybe display(df) works in other envs as well?
Should keep as is if there's some specific situation where display(df) will not cause try to fail, but is not desirable to execute?
There was a problem hiding this comment.
FYI from my terminal console (shell = TerminalInteractiveShell), both display(df) and print(df) work fine. They just give same output.
There was a problem hiding this comment.
Eg. in colab, I don't think shell == "ZMQInteractiveShell" but display(df) still would be preferred over print(df)
There was a problem hiding this comment.
Agree, but similarly do not know the answer to your last question. I can make this change, but it makes exception handling more challenging for developers in the future if we wish to expand this functionality.
EDIT: i see for some terminals that have jupyter, get_ipython().__class__.__name__ returns Shell, so will change to try: display(df)
There was a problem hiding this comment.
to your second and third comment, we still need error checking because in my console, i don't have IPython installed so it throws an error if i try to display
This PR adds three things to
dataset.health_summaryhealth_summaryin a terminal with no jupyter notebook, it should still print to console.pred_probsis not provided.