-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure display setting of Dataframe in 2.0 tutorial #215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 12 12
Lines 915 915
Branches 184 184
=======================================
Hits 873 873
Misses 16 16
Partials 26 26
Continue to review full report at Codecov.
|
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"%%HTML\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this be visible in the docs build and in the colab notebook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least need to replace metadata
above with:
"metadata": {
"nbsphinx": "hidden"
},
That will at least hide in the docs website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I believe so, the code will be visible. I'm not sure how to hide it though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually if you want to add this stuff to this notebook it should go into the cell that is already hidden (the one starting with # Package installation.
).
I'd add it before/after:
%config InlineBackend.print_figure_kwargs={"facecolor": "w"}
We should not have many hidden cells in one notebook, it makes the colab / local versions look too different from the docs website one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, agree. I moved it to the cell that is already hidden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Double check jonas's comment. After merge, double check it worked (takes a few minutes to load) and double check these settings and weird code blocks are not visible to user.
Configure display setting of Dataframe in 2.0 tutorial to address issues with background color of header in dark mode for docs.
Background color of rows will be addressed in another PR after 2.0 tagging.
Preview in dark mode of Jupyter Lab:
Preview in non-dark mode: