Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy docs when new release is tagged #219

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

weijinglok
Copy link
Contributor

This PR fixes the issue where docs are not deployed when a new release is tagged.

Previously, it only deploys if there is a trigger from the master branch. I've added an OR condition to also deploy if it's a trigger from a new release tag.

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #219 (31d2f2d) into master (966acf8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          12       12           
  Lines         915      915           
  Branches      184      184           
=======================================
  Hits          873      873           
  Misses         16       16           
  Partials       26       26           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966acf8...31d2f2d. Read the comment docs.

Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wonder why mockup did not catch this issue?

@jwmueller jwmueller merged commit f702b32 into cleanlab:master Apr 16, 2022
@weijinglok weijinglok deleted the fix-doc-deploy branch April 16, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants