Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize text tutorial to multiclass datasets #229

Merged
merged 6 commits into from
Apr 19, 2022

Conversation

calebchiam
Copy link
Contributor

The current training model assumes that the dataset has binary labels. This PR tweaks the model setup to generalize to datasets where there are >2 classes. As part of this change, the ROC-AUC score has been replaced with Log Loss.

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #229 (74ad3ff) into master (1746e63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          12       12           
  Lines         911      911           
  Branches      180      180           
=======================================
  Hits          873      873           
  Misses         14       14           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1746e63...74ad3ff. Read the comment docs.

less likely to be missed if users skip the previous cell to load their own datasets
Copy link
Contributor

@weijinglok weijinglok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! just a tiny comment to consider.

docs/source/tutorials/text.ipynb Outdated Show resolved Hide resolved
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call generalizing this to multiclass!
I just made 2 very minor edits

@jwmueller jwmueller merged commit 31c939f into master Apr 19, 2022
@jwmueller jwmueller deleted the patch/text-tutorial branch April 19, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants