Add missing ref to url links in OpenGraph metadata #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The opengraph extension for sphinx only links to https://docs.cleanlab.ai/[path/to/page].html, but should be https://docs.cleanlab.ai/[ref_name][path/to/page].html.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
=======================================
Coverage 96.91% 96.92%
=======================================
Files 71 71
Lines 5707 5716 +9
Branches 971 972 +1
=======================================
+ Hits 5531 5540 +9
Misses 91 91
Partials 85 85 ☔ View full report in Codecov by Sentry. |
|
Merging to test if deployed docs for the master branch work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opengraph extension for sphinx only links to
https://docs.cleanlab.ai/[path/to/page].html, but should behttps://docs.cleanlab.ai/[ref_name]/[path/to/page].html.where
ref_nameshould be eitherstable, master or a released version (e.g. v.2.6.0 in the future).Without this fix, all the links will fail a link-check.
This PR aims to fix that issue.