Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Company.marketCap casting int to string field #18

Closed
philipithomas opened this issue Dec 12, 2017 · 2 comments · Fixed by #19
Closed

Company.marketCap casting int to string field #18

philipithomas opened this issue Dec 12, 2017 · 2 comments · Fixed by #19

Comments

@philipithomas
Copy link
Contributor

I'm getting this error in production:

screen shot 2017-12-12 at 11 07 14 am

Simple fix would be converting the marketCap string field to an int. However, I'm concerned that the API isn't returning a consistent type.

@davidlumley @mattatcha - can you confirm the API return type? Until this is fixed, enrichment is erroring in our app while chewing through our quota . . .
@philipithomas
Copy link
Contributor Author

Here's the line https://github.com/clearbit/clearbit-go/blob/master/clearbit/company.go#L86

@davidlumley
Copy link
Contributor

Looks like it was accidentally changed from an int to a string here: ce4492d

Would you mind submitting a PR to change it back? 🙏

@philipithomas philipithomas mentioned this issue Dec 12, 2017
Merged
davidlumley pushed a commit that referenced this issue Dec 12, 2017
@philipithomas @davidlumley
Revert company marketcap to an int (#19)
943e11f 
* Revert marketcap to an int

closes #18

* format code with gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert company marketcap to an int
2 participants
@davidlumley @philipithomas