fix cluster resize #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Remove ignore changes for EBS volume size, it breaks resizes.
why
Impossible to (Terraform) resize a cluster with the current code and impossible to apply Terraform after a resize in the console, even after an import of the cluster.
I know there is ongoing work in cloudposse#101 that might also include a fix for this, but it looks like it will take more time to get that done. This is a basic fix.
references
AWS provider issue: hashicorp/terraform-provider-aws#26031
Cloudposse module issue: cloudposse#99
Upstream PR with this fix: cloudposse#103
Internal Asana: https://app.asana.com/0/1206364880660348/1206676435555704