logging: Use nanosecond timestamps #136
Conversation
|
kubernetes qa-passed 👍 |
|
|
||
| // enable nanosecond timestamps | ||
| proxyLog.Logger.Formatter = &logrus.TextFormatter{ | ||
| TimestampFormat: time.RFC3339Nano, |
There was a problem hiding this comment.
just whilst I'm here, not sure if directly related - I noticed our logs were putting in timezone info like BST+1 etc. - would it be possible for us to move all the time logging to UTC, and hence drop the extra noise?
There was a problem hiding this comment.
That's happening for the runtime so we can look at that separately...
This change modifies the proxy timestamps from:
2017-09-28T08:52:45+01:00
to:
2017-09-29T08:52:45.176464812+01:00
The TZ is in there, but encoded numerically as an offset.
|
Another occurrence of Jenkins not updating the github status it seems as the 16.04 was successful. Force-push-updating... |
jodh-intel
force-pushed
the
use-nanosecond-timestamps
branch
from
232d3bd
to
aa331c1
Compare
|
I thought I'd have a peek - I see the force push has kicked off another jenkins, but the previous jenkins build I think is saying 'aborted' on the top level status. Build Hmm, yeah, the end of the log says: So, I'm not sure it was successful, but I can't find why in the logs |
|
Ugh - I didn't see that error because the Jenkins console doesn't show it! You seemingly have to view the raw log to see the last line! ;-( |
|
Reported as clearcontainers/jenkins#12. |
|
kubernetes qa-failed 👎 |
jodh-intel
force-pushed
the
use-nanosecond-timestamps
branch
from
aa331c1
to
490a6b9
Compare
|
kubernetes qa-failed 👎 |
|
Sigh - the 16.04 CI job is invalid (404 error). Re-pushing... |
jodh-intel
force-pushed
the
use-nanosecond-timestamps
branch
from
490a6b9
to
626d26c
Compare
|
kubernetes qa-passed 👍 |
Switch from second-resolution timestamps to nanosecond-resolution for greater precision and consistency with the runtime and agent. Fixes clearcontainers#135. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
use-nanosecond-timestamps
branch
from
626d26c
to
b43cbce
Compare
|
kubernetes qa-passed 👍 |
Switch from second-resolution timestamps to nanosecond-resolution for
greater precision and consistency with the runtime and agent.
Fixes #135.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com