Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

only pull test docker image if not present locally #653

Closed
jodh-intel opened this issue Sep 29, 2017 · 0 comments
Closed

only pull test docker image if not present locally #653

jodh-intel opened this issue Sep 29, 2017 · 0 comments
Assignees

Comments

@jodh-intel
Copy link
Contributor

The unit-tests need a busybox docker image to generate an OCI bundle from. Currently, the tests always docker pull busybox twice (once for a non-priv user and once for root).

Modify the behaviour so that if the image exists locally, don't call docker pull busybox at all, which will speed up the overall unit-test runtime.

@jodh-intel jodh-intel self-assigned this Sep 29, 2017
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Sep 29, 2017
Change the unit-test setup code to only download the "busybox" docker
image if it doesn't already exist locally. Since the unit-tests are run
twice (once as a non-privileged user and once as `root`), this can speed
up the overall unit-test runtime significantly.

Fixes clearcontainers#653.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
mcastelino pushed a commit to mcastelino/runtime that referenced this issue Dec 6, 2018
Apply all supported memory constraints to the contrainer
inside the virtual machine.

fixes clearcontainers#653

Signed-off-by: Julio Montes <julio.montes@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants