This repository has been archived by the owner on May 6, 2020. It is now read-only.
Configuration: Add support for fine grained control of memory management and debug #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optionally enable support for pre-allocation of all of the memory corresponding to the Clear Containers VM. This is useful in latency sensitive use cases. This results in hard allocation of all the RAM requested for the container/pod. Fixes #568 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
Add support for fine grained control of memory management. enable_prealloc=true will result in the upfront allocation and locking down of all VM memory, resulting in lower VM density. enable_swap=true will enable swap of VM memory, resulting in higher VM density with potentially higher latency Fixes #568 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
Enable hypervisor and container kernel logs. Once debug is enabled these logs can be obtained in the cc-proxy logs or by stopping the cc-proxy service and running the cc-proxy explicitly. /usr/libexec/clear-containers/cc-proxy -log debug This option is useful to trouble shoot errors in the kernel or when the agent in the container fails to launch. Fixes #568 Fixes #568 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
Fix unit test case failures introduced due to new memory management options. Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
grahamwhaley
approved these changes
Sep 20, 2017
config/configuration.toml.in
Outdated
| # | ||
| # Enable swap of vm memory. Default false. | ||
| # The behaviour is undefined if mem_prealloc is also set to true | ||
| #enable_swap = true |
There was a problem hiding this comment.
still would have been nice to have a description of what this gains or looses if you enable etc.
| @@ -112,6 +112,7 @@ DEFMEMSZ := 2048 | |||
| DEFDISABLEBLOCK := false | |||
There was a problem hiding this comment.
nit: there is a double 'fixes' in the commit message?
|
lgtm
|
Closed
jodh-intel
reviewed
Oct 9, 2017
| @@ -281,6 +290,9 @@ $(CONFIG): $(CONFIG_IN) $(GENERATED_FILES) | |||
| -e "s|@DEFVCPUS@|$(DEFVCPUS)|g" \ | |||
| -e "s|@DEFMEMSZ@|$(DEFMEMSZ)|g" \ | |||
| -e "s|@DEFDISABLEBLOCK@|$(DEFDISABLEBLOCK)|g" \ | |||
| -e "s|@DEFENABLEMEMPREALLOC@|$(DEFENABLEMEMPREALLOC)|g" \ | |||
| -e "s|@DEFENABLEMSWAP@|$(DEFENABLESWAP)|g" \ | |||
| -e "s|@DEFENABLEMSWAP@|$(DEFENABLEDEBUG)|g" \ | |||
There was a problem hiding this comment.
Hi @mcastelino - In passing, I've just spotted the above, which won't work as expected I think.
There was a problem hiding this comment.
@jodh-intel thanks for catching this. This is a bug. I will send a PR to address this.
mcastelino
pushed a commit
to mcastelino/runtime
that referenced
this pull request
Dec 6, 2018
…rtVSocks cli: kata-env: show if vsocks are supported
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for fine grained control of memory management.
Enabling the two together results in undefined behavior.
Fixes #568