Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to "Create a Clear Linux* based web server" tutorial (resolves issue #256). #263

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Updates to "Create a Clear Linux* based web server" tutorial (resolves issue #256). #263

merged 2 commits into from
Oct 10, 2018

Conversation

krisdale
Copy link
Contributor

@krisdale krisdale commented Oct 9, 2018

Signed-off-by: Kristal Dale kristal.dale@intel.com

@krisdale
- Applied requested updates from issue clearlinux#256. Verified chang…
6ed2ba3 
…es/full tutorial.

- Minor grammatical/text edits for clarity.

Signed-off-by: Kristal Dale <kristal.dale@intel.com>
@krisdale krisdale requested a review from mvincerx October 9, 2018 00:13
@krisdale
Copy link
Contributor Author

krisdale commented Oct 9, 2018

I would like to add @odwdinc as reviewer, as the changes were originally requested by @odwdinc.

@mvincerx
Copy link
Contributor

mvincerx commented Oct 9, 2018

Invitation sent to @odwdinc to join as collaborator.

@krisdale krisdale changed the title Applied requested updates from issue #256. Updates to "Create a Clear Linux* based web server" tutorial (resolves issue #256). Oct 9, 2018
odwdinc
odwdinc reviewed Oct 9, 2018
View reviewed changes
Copy link
Contributor

@odwdinc odwdinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good form my end

@krisdale
Copy link
Contributor Author

krisdale commented Oct 9, 2018

Thanks @odwdinc !

@mvincerx
Copy link
Contributor

mvincerx commented Oct 9, 2018 •
edited
Loading

These are great refinements to this tut! @krisdale just one minor change.
Please remove the backticks, as used to style shazam , from the stateless hyper link at very bottom.
Then I'm ready to merge it.

mvincerx
mvincerx reviewed Oct 9, 2018
View reviewed changes
Copy link
Contributor

@mvincerx mvincerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is directly on PR. One microscopic edit.

@krisdale
Remove unneeded back ticks from stateless link definition.
386acea 
Signed-off-by: Kristal Dale <kristal.dale@intel.com>
@krisdale
Copy link
Contributor Author

krisdale commented Oct 9, 2018

@mvincerx Backticks removed :)

@mvincerx
Copy link
Contributor

LGTM.

@mvincerx mvincerx merged commit bd693d2 into clearlinux:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odwdinc odwdinc odwdinc left review comments

@mvincerx mvincerx mvincerx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krisdale @mvincerx @odwdinc