Add inference and multinode guide page for DLRS stack #877
Conversation
There was a problem hiding this comment.
Overall, looks great. The main challenge here is "How to better...":
- Distinguish what is required vs. what's optional
- Thread together all the subsections to explain how they relate to using DLRS with Seldon Core.
- Define purpose. See sentence "we explore a solution for using the Deep Learning Reference Stack with a Seldon Core*..." A guide needs to propose a specific set of procedures to reach a goal, or optionally, multiple goals. Rather than explore, consider defining a specific path to completion.
| ******** | ||
|
|
||
| The solution covered here uses the following software components: | ||
|
|
There was a problem hiding this comment.
I think we're missing an opportunity here. The Overview lacks a clear explanation of how all of these components are used in concert. A simple, succinct sentence will solve this like a shot to the heart. I recommend adding that "goal" statement here--relating how all these components fit together. Also, I'd like to see these components as short, uniform descriptions. I think what's missing here is the "keystone" sentence at the beginning (above); then each one of these descriptions can explain how it serves that goal.
There was a problem hiding this comment.
@bd-dean. BTW: For comparison, I like the intro sentences in the Overview of the main DLRS guide. Maybe you could write something similar here.
There was a problem hiding this comment.
What do you think?
IMHO: If this solution requires all of these components, it should use "requires" instead of "uses". I'm hoping there could be a simple, direct sentence without nuance.
| ******** | ||
|
|
||
| The solution covered here uses the following software components: | ||
|
|
There was a problem hiding this comment.
What do you think?
IMHO: If this solution requires all of these components, it should use "requires" instead of "uses". I'm hoping there could be a simple, direct sentence without nuance.
|
@bd-dean. Thanks for the last few commits here. What are we waiting on for this PR? Any blockers? |
|
Hey @bd-dean. What's the status on this PR? Are there any blockers? |
|
@mvincerx we’re waiting in clearance to release the feature and then can pull the trigger on this PR. |
|
Thanks for the update. |
|
Hey @bd-dean. Are we still on hold for this? |
|
LGTM. |
This will add the ai-inference instructions. Note that this document has some outstanding TODO issues, so it cannot be merged -- need to verify links & ENV values.