Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testlib: If skipping a test, the setup should also skip #1486

Open
castulo opened this issue Apr 20, 2020 · 1 comment
Open

Testlib: If skipping a test, the setup should also skip #1486

castulo opened this issue Apr 20, 2020 · 1 comment
Labels
testing

Comments

@castulo
Copy link
Contributor

castulo commented Apr 20, 2020

Currently when a test is marked to be skipped, the test_setup for that test is still run. This could be skipped since the test is not going to run.

Currently we are considering caching the creation of test resources, if we do that then this issue is no longer relevant.
@otaviobp
Copy link
Contributor

It would be great to be able to set all tests of a file to be skipped only once instead of having multiple checks for RUNNING_IN_CI like we have today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@otaviobp @castulo