Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compressed/uncompressed size mismatch unzipping some nugets #178

Closed
dabutvin opened this issue Oct 9, 2018 · 1 comment · Fixed by #183
Closed

compressed/uncompressed size mismatch unzipping some nugets #178

dabutvin opened this issue Oct 9, 2018 · 1 comment · Fixed by #183

Comments

@dabutvin
Copy link
Member

dabutvin commented Oct 9, 2018

The errors look like:

compressed/uncompressed size mismatch for stored file: 2 != 0

This is coming from an optional validation in yauzl see thejoshwolfe/yauzl#53

They have an option to disable this validation, which we could use since we are not in control of the format of these zips.

The tricky part is we are using yauzl through https://github.com/kevva/decompress-unzip/blob/master/package.json which is not up to date with the version that exposes it as an option.

The option would go here next to lazyEntries

it would be

validateEntrySizes: false
@dabutvin
Copy link
Member Author

dabutvin commented Oct 16, 2018

Here is the plan

  • fork decompress-unzip and expose yauzl options
  • install their decompress-targz and our fork of decompress-unzip from github
  • configure decompress to use our plugins with the opts override

dabutvin pushed a commit to dabutvin/crawler that referenced this issue Oct 16, 2018
dabutvin added a commit that referenced this issue Oct 23, 2018
fork decompress-unzip to turn off validation #178
qtomlinson pushed a commit to qtomlinson/crawler that referenced this issue Feb 6, 2024
qtomlinson pushed a commit to qtomlinson/crawler that referenced this issue Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant