Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib 3.4.0 #10486

Merged
merged 5 commits into from
May 18, 2021
Merged

matplotlib 3.4.0 #10486

merged 5 commits into from
May 18, 2021

Conversation

clearlydefinedbot
Copy link
Contributor

Type: Missing

Summary:
matplotlib 3.4.0

Details:
Add 0BSD License

Resolution:
License Url:
https://matplotlib.org/stable/devel/license.html

Description:

Pull request generated by Microsoft tooling.

Affected definitions:

@clearlydefinedbot
Copy link
Contributor Author

You can review the change introduced to the full definition at ClearlyDefined.

@AE49 AE49 self-assigned this Apr 6, 2021
@AE49
Copy link
Contributor

AE49 commented Apr 6, 2021

@capfei This could be Declared as PSF-2.0. PyPI metadata is PSF. The license is a close enough match with references to PSF and Python customized, but main licensing text was not changed. https://matplotlib.org/stable/users/license.html. Thoughts?

https://github.com/matplotlib/matplotlib/blob/v3.4.0/LICENSE/LICENSE

@capfei
Copy link
Member

capfei commented Apr 6, 2021

@ariel11 I do see that only the author information was changes and the copyright years, which, in most cases, we would accept as being that license. I'm not sure about the part referring versions prior to 1.3.0. Do we count that as part of the full license text or treat it individually?

@ariel11 What do you think?

@ariel11
Copy link
Contributor

ariel11 commented Apr 9, 2021

@AE49 and @capfei - The Matplotlib license does not currently meet the SPDX matching guidelines as the author text is not in colored font - https://spdx.org/licenses/PSF-2.0.html. I think it should be in colored font and I can submit that request to SPDX. It looks like we curated a different version of Matplotlib as OTHER.

I found this issue has been raised with SPDX (spdx/license-list-XML#1104) and it sounds like the author and date text will be changed to colored font. If that is the case, then I think PSF-2.0 would work here.

@AE49
Copy link
Contributor

AE49 commented Apr 20, 2021

@ariel11 @capfei Are we waiting first on the SPDX resolution or should I merge this PR now with PSF-2.0 as the Declared License?

@ariel11
Copy link
Contributor

ariel11 commented Apr 20, 2021

@AE49 - My suggestion would be to proceed with PSF-2.0

@capfei
Copy link
Member

capfei commented Apr 22, 2021

I tried to fix these but it keeps failing. Added to #11048

@nellshamrell nellshamrell reopened this Apr 26, 2021
@AE49 AE49 mentioned this pull request Apr 27, 2021
@github-actions github-actions bot added the merge conflict GitHub Action bot will auto add/remove this label when there's a conflict. label Apr 27, 2021
@capfei capfei added the issue There is a tooling or process based issue or question. label Apr 27, 2021
@github-actions
Copy link

Conflicts have been resolved.

@github-actions github-actions bot removed the merge conflict GitHub Action bot will auto add/remove this label when there's a conflict. label Apr 27, 2021
@nellshamrell nellshamrell reopened this Apr 28, 2021
@clearlydefinedbot
Copy link
Contributor Author

We discovered some errors in this curation when validating it:

2.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.1 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.3 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.4 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.1 licensed.declared with value "PSF-2.0" is not SPDX compliant

@clearlydefinedbot
Copy link
Contributor Author

We discovered some errors in this curation when validating it:

2.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.1 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.3 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.4 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.1 licensed.declared with value "PSF-2.0" is not SPDX compliant

@github-actions github-actions bot added the merge conflict GitHub Action bot will auto add/remove this label when there's a conflict. label May 10, 2021
@clearlydefinedbot
Copy link
Contributor Author

We discovered some errors in this curation when validating it:

2.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.1 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.3 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.4 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.1 licensed.declared with value "PSF-2.0" is not SPDX compliant

@github-actions
Copy link

Conflicts have been resolved.

@github-actions github-actions bot removed the merge conflict GitHub Action bot will auto add/remove this label when there's a conflict. label May 11, 2021
@clearlydefinedbot
Copy link
Contributor Author

We discovered some errors in this curation when validating it:

2.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.1 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.3 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.4 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.1 licensed.declared with value "PSF-2.0" is not SPDX compliant

@clearlydefinedbot
Copy link
Contributor Author

We discovered some errors in this curation when validating it:

2.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.0.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.2.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.1 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.2 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.3 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.3.4 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.0 licensed.declared with value "PSF-2.0" is not SPDX compliant
3.4.1 licensed.declared with value "PSF-2.0" is not SPDX compliant

@ariel11 ariel11 merged commit 0390b82 into master May 18, 2021
@ariel11 ariel11 deleted the clearlydefinedbot_210405_214133.895 branch May 18, 2021 20:35
@AE49 AE49 removed their assignment May 24, 2021
@capfei capfei mentioned this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue There is a tooling or process based issue or question.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants