Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dashes to SPDX expressions in various Maven curations #7937

Merged
merged 3 commits into from
Nov 6, 2020

Conversation

sschuberth
Copy link
Member

@sschuberth sschuberth commented Nov 5, 2020

FYI @nnobelis.

@sschuberth
Copy link
Member Author

@jeffmcaffer isn't there a way we could have a PR check to validate that curated license expressions are actually valid SPDX expressions (modulo maybe OTHER, also see our discussion in that regard)?

@capfei
Copy link
Member

capfei commented Nov 6, 2020

I would love to have expression validation! I have made my fair share of typos when making corrections. 😞

@capfei capfei merged commit 85d3ec8 into master Nov 6, 2020
@capfei capfei deleted the sschuberth/fix-spdx-expressions-dashes branch November 6, 2020 00:48
@jeffmcaffer
Copy link
Member

PR validation is a great idea. we have an spdx library that should be able to do that work so putting together an action should be straight forward.

cc @nellshamrell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants