Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templatize code #175

Merged
merged 7 commits into from
Mar 25, 2020
Merged

Templatize code #175

merged 7 commits into from
Mar 25, 2020

Conversation

AntoineRondelet
Copy link
Contributor

Used templates in functions manipulating field elements to support arbitrary fields

@AntoineRondelet AntoineRondelet mentioned this pull request Mar 23, 2020
Closed
dtebbs
dtebbs suggested changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Can ignore the points about const ref for now, if you prefer.)

src/libsnark_helpers/extended_proof.tcc Outdated Show resolved Hide resolved
src/util_api.hpp Outdated Show resolved Hide resolved
src/libsnark_helpers/debug_helpers.hpp Outdated Show resolved Hide resolved
dtebbs
dtebbs approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AntoineRondelet AntoineRondelet merged commit 95944e1 into develop Mar 25, 2020
@AntoineRondelet AntoineRondelet deleted the templatize-code branch April 7, 2020 11:36
AntoineRondelet added a commit that referenced this pull request May 6, 2020
@AntoineRondelet
Merge pull request #175 from clearmatics/templatize-code
8bd29fb 
Templatize code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtebbs dtebbs dtebbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AntoineRondelet @dtebbs