-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization refactor #177
Conversation
…arameterize the build
29fef48
to
522b370
Compare
5d69231
to
de51f4d
Compare
Fixed broken link
|
Sure |
Some inconsistent local includes still remaining: $ git grep 'include <libzeth'
libzeth/circuits/circuits-utils.cpp:#include <libzeth/circuits/circuits-utils.hpp>
libzeth/circuits/commitments/commitment.hpp:#include <libzeth/circuits/commitments/commitment.tcc>
libzeth/circuits/merkle_tree/merkle_path_selector.hpp:#include <libzeth/circuits/merkle_tree/merkle_path_selector.tcc>
libzeth/circuits/notes/note.tcc:#include <libzeth/circuits/notes/note.hpp>
libzeth/circuits/safe_arithmetic.cpp:#include <libzeth/circuits/safe_arithmetic.hpp>
libzeth/circuits/sha256/sha256_ethereum.hpp:#include <libzeth/circuits/sha256/sha256_ethereum.tcc>
libzeth/circuits/sha256/sha256_ethereum.tcc:#include <libzeth/circuits/circuits-utils.hpp>
libzeth/libsnark_helpers/debug_helpers.hpp:#include <libzeth/libsnark_helpers/debug_helpers.tcc>
libzeth/libsnark_helpers/extended_proof.tcc:#include <libzeth/snarks_core_imports.hpp>
libzeth/snarks/groth16/core/computation.tcc:#include <libzeth/snarks/groth16/core/computation.hpp>
libzeth/snarks/groth16/mpc/chacha_rng.cpp:#include <libzeth/snarks/groth16/mpc/chacha_rng.hpp>
libzeth/snarks/groth16/mpc/multi_exp.tcc:#include <libzeth/snarks/groth16/mpc/multi_exp.hpp>
libzeth/snarks/groth16/mpc/phase2.cpp:#include <libzeth/snarks/groth16/mpc/phase2.hpp>
libzeth/snarks/groth16/mpc/powersoftau_utils.cpp:#include <libzeth/snarks/groth16/mpc/powersoftau_utils.hpp>
libzeth/test/mimc_mp_test.cpp:#include <libzeth/circuits/mimc/mimc_mp.hpp>
libzeth/test/simple_test.hpp:#include <libzeth/include_libsnark.hpp>
libzeth/types/bits.cpp:#include <libzeth/types/bits.hpp>
libzeth/types/bits.tcc:#include <libzeth/types/bits.hpp>
libzeth/types/merkle_tree_field.hpp:#include <libzeth/types/merkle_tree_field.tcc>
libzeth/types/merkle_tree_field.tcc:#include <libzeth/circuits/mimc/mimc_mp.hpp>
libzeth/types/note.hpp:#include <libzeth/types/bits.hpp>
libzeth/util.tcc:#include <libzeth/util.hpp>
libzeth/util_api.cpp:#include <libzeth/util_api.hpp>
libzeth/util_api.tcc:#include <libzeth/util_api.hpp>
mpc_tools/mpc_phase2/cli/mpc_common.hpp:#include <libzeth/circuit_types.hpp>
mpc_tools/mpc_phase2/cli/mpc_phase2_contribute.cpp:#include <libzeth/snarks/groth16/mpc/phase2.hpp>
mpc_tools/mpc_phase2/cli/mpc_phase2_verify_contribution.cpp:#include <libzeth/snarks/groth16/mpc/phase2.hpp>
mpc_tools/mpc_phase2/cli/mpc_phase2_verify_transcript.cpp:#include <libzeth/snarks/groth16/mpc/phase2.hpp>
mpc_tools/mpc_phase2/mpc_client.cpp:#include <libzeth/circuit_wrapper.hpp>
mpc_tools/mpc_phase2/mpc_coord.cpp:#include <libzeth/circuit_wrapper.hpp>
mpc_tools/mpc_phase2/test/mpc_test_cli.cpp:#include <libzeth/test/simple_test.hpp> |
Thanks @dtebbs ... |
This PR:
include
directivesmpc
commands tompc-<role>-phase2
, where<role>
is eithercoord
(for coordinator) orclient
coinstore
,trusted_setup
andkeystore
directories which are now ignored from the git flow but are created locally via thesetup
scriptNot addressed in this ticket, but "to do":
pyClient
topy_client
to stick to the snake case naming conventioncoinstore
tonotestore
to be consistent with the vocabulary of Zethzeth-contracts
tozeth_contracts
to stick to the snake case naming conventionpip
seems to be only supported from v10 onward: Allow passing a --no-progress-bar to the install script to surpress progress bar pypa/pip#4194. As such calling the mpc script with a pip of version < 10.0 will cause an error (https://github.com/clearmatics/zeth/blob/develop/scripts/mpc_setup#L20). Likewise, some scripts assume thattruffle
is installed.), and we need to specify which version ofclang-format
is required to run the formatting script (especially if we want to use the script in a git hook Added pre-commit hook to run format script #173)