Refactor libsnark helpers [depends on #200] #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtebbs
force-pushed
the
refactor-libsnark-helpers
branch
3 times, most recently
from
d11f25b
to
a79fd88
Compare
dtebbs
commented
Apr 30, 2020
dtebbs
changed the title
dtebbs
changed the title
dtebbs
force-pushed
the
refactor-libsnark-helpers
branch
from
836ef4a
to
cfe6813
Compare
dtebbs
changed the title
|
Removed the WIP. As above, this PR does not address refactoring of the serialization functions, or renaming. It aims to decide on the file divisions / locations and to expse the snarks in a slightly more versatile way. Further PRs will follow, but flag anything that you think makes sense to include here. |
dtebbs
force-pushed
the
refactor-libsnark-helpers
branch
from
cfe6813
to
c032915
Compare
dtebbs
force-pushed
the
refactor-libsnark-helpers
branch
from
c032915
to
71ba0ed
Compare
dtebbs
force-pushed
the
refactor-libsnark-helpers
branch
from
71ba0ed
to
e2dbc3b
Compare
|
All comments above should have been addressed now (commenting here rather than on all individual threads). |
|
LGTM |
AntoineRondelet
added a commit
that referenced
this pull request
May 6, 2020
Refactor libsnark helpers [depends on #200]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranging files and the snark abstractions to parameterize by snark.
Part of a larger cleanup, this PR focussed on these two points and remaining clean up will happen in future PRs.