-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary support for local keys #239
Conversation
472d6d5
to
888e46e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a quick one even if still WIP
13cabc1
to
f9ba856
Compare
f9ba856
to
50f749e
Compare
@dtebbs there's a box that isn't ticked yet in your PR description. Do I need to treat this PR as still WIP or did you forget to tick the box? |
@AntoineRondelet Sorry - I forgot to update it. Good catch. |
help=f"Ethereum rpc end-point") | ||
"--eth-network", | ||
default=None, | ||
help="Ethereum RPC endpoint, network or config file " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be possible to stick to one type of values here? I mean: do we really need the 3 potential value types?
I find it confusing to see that a flag can take 3 type of values (a URL or a "name" or a file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely get the point. I'm sure it can be improved with more time invested, but my thinking was that each of these forms is a potential use-case, and there should not really be any ambiguity when specifying this. I considered having multiple flags to cover different types, but that would involve quite a bit more complexity and logic to resolve some ambiguous cases like multiple flags being given, overriding each other and falling though to defaults, etc.
So this seemed like a simple solution that avoids ambiguity, but definitely happy to iterate if there is a better way to expose the same functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I'll open a ticket to keep this in mind and polish this going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #249 to track this
50f749e
to
8ed9444
Compare
…port for network types
…pts accept network name.
8ed9444
to
38b2518
Compare
(pushed a small fix for the client syncing code, but no other changes planned now) |
Client changes to suppot geth-style nodes, such as autonity (depends on #239)
eth-private-key
if present to locally sign the tx (as well aseth-address
as before)eth-private-key
andeth-address
in the current dirweb3.eth.accounts[0]
unless told otherwise) assuming gnache / geth with hosted accounts.scripts/test_zeth_cli
callsetup_user
inscripts/test_zeth_client_common.sh
to extract a (funded) hosted address from the RPC host. Create two setup functionssetup_user_local_key
(userd for alice, bob, charlie in the test script) andsetup_user_hosted_key
(used for deployer in the test scripts)eth-private-key
scripts/test_zeth_client_common.sh
) use the correct addresses