-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPC] Phase2 MPC #73
[MPC] Phase2 MPC #73
Conversation
53aceb9
to
ecf0bda
Compare
e344171
to
89817d2
Compare
98c0df8
to
7fe08a6
Compare
ecf0bda
to
2a98583
Compare
b01d4db
to
ffa9c39
Compare
80ddcec
to
fe1d473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some comments to clarify some of the choices you took in the chacha files, or refer to the corresponding sections of the implementation you followed
(@AntoineRondelet for some reason, github is not letting me reply directly, so I've had to move this to a new comment). I've added some comments to explain these functions and why they are here. Just in case it's not clear, this code will only work for the case where Since this is a concrete function, if it was in a .tcc file it would likely cause link errors due to the symbol being defined multiple times. If we turned it into fully generic code with Let me know if the comments are not clear, or you think we should take a different approach. |
Yes. What I was saying was basically: if this is not generic code, then let's remove the [EDIT] I thought the compiler would not complain if we removed |
…nd to match contributions
LGTM |
Functions and cli utils to perform the phase2 MPC.
Some things that are still WIP / need discussion:
(depends on #68)