Blake cleanup #87
Merged
Blake cleanup #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So then, let's follow the same approach for the files with name collision and have something like |
|
@AntoineRondelet The changes done so far are mostly about comments, ifndef, some renaming and a few includes that I removed or replaced (snark_alias in some circuits, and mimc_mp in note.hpp). Please have a look when you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up comments and ifndef in blake (as well as some file names) for consistency.
I had to add "_type" for the ifndef of the types/* files as types/note.hpp would have had the same flag (with the circuit's one) (and then for consistency).