Updated install script to allow adding multiple launch files to a job #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| j.add(package=pkg, glob=os.path.join(pkgpath, "*")) | ||
| found_path = find_in_workspaces(project=pkg, path=pkgpath, first_match_only=True) | ||
| if not found_path: | ||
| print "Unable to locate path %s in package %s. Installation aborted." % (pkgpath, pkg) |
|
@mikepurvis Any other comments? |
|
Looks good, thanks. Sorry this fell of my radar. |
mikepurvis
added a commit
that referenced
this pull request
Nov 30, 2015
Updated install script to allow adding multiple launch files to a job
|
Backported to indigo in cd217fb. Released: ros/rosdistro#9906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted argparse to accept multiple
pkgpatharguments and changed the code to loop over the resulting list and add each entry to theJobobject.Proposed to make the install script more convenient for users who wish to install several launch files all at once with one command.
I regenerated the documentation locally and it automatically updated to reflect this change, so I don't believe any manual changes are necessary. I am happy to make any changes if necessary though.
I would also like to have this change backported to Indigo. I'm assuming the usual procedure is to make the change on the jade-devel branch and then backport.