Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a --wait flag to launch file to the install script #72

Closed
msadowski opened this issue Sep 5, 2018 · 2 comments
Closed

Adding a --wait flag to launch file to the install script #72

msadowski opened this issue Sep 5, 2018 · 2 comments

Comments

@msadowski
Copy link
Contributor

Hi!

This might be slightly tangential to #16. I noticed that the only clean way to add a --wait flag to the launch file is through the python API?

In a system with multiple machines and a single master it might be desired to wait for the master to start launchfiles (otherwise a launch will not be successful if it's execute before master comes up).

I'm more than happy to try to add this feature and make a PR if you think it's desired.
@msadowski msadowski changed the title Adding a --wait flag to launch file in the install script Adding a --wait flag to launch file to the install script Sep 26, 2018
@130s
Copy link
Contributor

130s commented Sep 22, 2019

I think this is addressed already by #73

@msadowski
Copy link
Contributor Author

Yes it is, closing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@130s @msadowski