Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #45 by recursively invoking the cache checker if needed, but I want to have a discussion surrounding it before it gets merged in. Specifically, two things I want to discuss:
self
fromrender
. Do we care?while
loop is not invoked, but the conditional, while pretty cheap, isn't free and is potentially invoked thousands of times during a render. Even cheap things can get expensive in loops.CachedRender
is intended to keep our apps fast. If it adds significant overhead, we should decide whether to support this use case.cc @balmoral